Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: use a configurable value for number of open Dependabot PRs #56427

Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 1, 2025

This way, we can disable all dependabot PRs from private forks – I'm fed up with the flow of useless notifications coming from our nodejs-private org.

This way, we can disable all dependabot PRs from private forks.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 1, 2025
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this should be a secret

@@ -8,15 +8,15 @@ updates:
interval: monthly
commit-message:
prefix: meta
open-pull-requests-limit: 10
open-pull-requests-limit: ${{secrets.OPEN_PR_LIMIT}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
open-pull-requests-limit: ${{secrets.OPEN_PR_LIMIT}}
open-pull-requests-limit: ${{vars.OPEN_PR_LIMIT}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me, but I'm not sure it exists, I have only be able to find dependabot secrets, not variables.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nevermind. I thought this was a github action.

.github/dependabot.yml Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 2, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2025
@nodejs-github-bot nodejs-github-bot merged commit 01554f3 into nodejs:main Jan 3, 2025
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 01554f3

@aduh95 aduh95 deleted the no-more-private-dependabot-prs branch January 3, 2025 22:18
targos pushed a commit that referenced this pull request Jan 13, 2025
This way, we can disable all dependabot PRs from private forks.

PR-URL: #56427
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants