-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: use a configurable value for number of open Dependabot PRs #56427
tools: use a configurable value for number of open Dependabot PRs #56427
Conversation
This way, we can disable all dependabot PRs from private forks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this should be a secret
@@ -8,15 +8,15 @@ updates: | |||
interval: monthly | |||
commit-message: | |||
prefix: meta | |||
open-pull-requests-limit: 10 | |||
open-pull-requests-limit: ${{secrets.OPEN_PR_LIMIT}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open-pull-requests-limit: ${{secrets.OPEN_PR_LIMIT}} | |
open-pull-requests-limit: ${{vars.OPEN_PR_LIMIT}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me, but I'm not sure it exists, I have only be able to find dependabot secrets, not variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nevermind. I thought this was a github action.
Landed in 01554f3 |
This way, we can disable all dependabot PRs from private forks. PR-URL: #56427 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This way, we can disable all dependabot PRs from private forks – I'm fed up with the flow of useless notifications coming from our nodejs-private org.